Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github: prettify DCO check display name #3113

Merged
merged 2 commits into from
Aug 31, 2023
Merged

.github: prettify DCO check display name #3113

merged 2 commits into from
Aug 31, 2023

Conversation

AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva commented Aug 30, 2023 •
edited
Loading

Unify it with tests workflow and make the name pretty.

Before:
Screenshot from 2023-08-30 15-00-20

After:
image

@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Merging #3113 (f330aaf) into master (ad24aad) will decrease coverage by 0.02%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3113      +/-   ##
==========================================
- Coverage   84.90%   84.89%   -0.02%     
==========================================
  Files         329      329              
  Lines       44239    44239              
==========================================
- Hits        37563    37555       -8     
- Misses       5168     5172       +4     
- Partials     1508     1512       +4
Files Changed Coverage Δ
pkg/services/rpcsrv/server.go 80.58% <ø> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

roman-khimov
roman-khimov reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But maybe it's better this way here.

.github/workflows/run_tests.yml Outdated
@@ -153,3 +153,7 @@ jobs:

- name: Run tests
run: go test -v -race ./...

dco:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not exactly a test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the updated version, how about it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we'll add something else later to the Contribution guidelines.

@AnnaShaleva AnnaShaleva force-pushed the prettify-dco branch 2 times, most recently from 930626d to bf3c1a0 Compare August 30, 2023 13:48
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@AnnaShaleva
.github: prettify DCO check display name
c80702c 
Extend the YAML scope and prettify the job check name.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
.github: rename testing workflow file
f330aaf 
Make it unified with the rest of workflow files.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
Copy link
Member Author

@roman-khimov, this happens due to CodeQL workflow file renaming, and I think it's OK.

@roman-khimov roman-khimov merged commit abb35ad into master Aug 31, 2023
13 of 18 checks passed
@roman-khimov roman-khimov deleted the prettify-dco branch August 31, 2023 08:58
@AnnaShaleva AnnaShaleva mentioned this pull request Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnnaShaleva @roman-khimov